X-Git-Url: https://uglyman.kremlin.cc/gitweb/gitweb.cgi?p=systembsd.git;a=blobdiff_plain;f=src%2Finterfaces%2Fhostnamed%2Fhostnamed.c;h=ec7156f1bab6502e72d8e71b140ebf231e358872;hp=19a196cc62929b2cdd346176a9b94ed7c267580f;hb=057ab9c2481d5ade30273e1069357b7c839e184c;hpb=904d744df98f63a70ec8832764bdfba1adda073a diff --git a/src/interfaces/hostnamed/hostnamed.c b/src/interfaces/hostnamed/hostnamed.c index 19a196c..ec7156f 100644 --- a/src/interfaces/hostnamed/hostnamed.c +++ b/src/interfaces/hostnamed/hostnamed.c @@ -34,6 +34,8 @@ #include "hostnamed-gen.h" #include "hostnamed.h" +#include "../../polkit-auth.h" + /* format: { * (1) string to be matched against runtime machine's sysctl output. * can be either the exact string or a substring contained @@ -110,8 +112,7 @@ const gchar *server_archs[] = { /* --- begin method/property/dbus signal code --- */ -/* TODO the extra boolean passed to these funcs is for policykit auth */ -/* TODO complete call with error, message, etc */ +/* TODO free some strings here */ static gboolean on_handle_set_hostname(Hostname1 *hn1_passed_interf, GDBusMethodInvocation *invoc, @@ -119,31 +120,71 @@ on_handle_set_hostname(Hostname1 *hn1_passed_interf, gpointer data) { GVariant *params; gchar *proposed_hostname, *valid_hostname_buf; - gboolean policykit_auth, ret; - size_t check_length, bad_length; + const gchar *bus_name; + gboolean policykit_auth, ret, try_to_set; + size_t check_length; + check_auth_result is_authed; - bad_length = MAXHOSTNAMELEN + 1; proposed_hostname = NULL; - ret = FALSE; + ret = try_to_set = FALSE; params = g_dbus_method_invocation_get_parameters(invoc); g_variant_get(params, "(sb)", &proposed_hostname, &policykit_auth); + bus_name = g_dbus_method_invocation_get_sender(invoc); - if(proposed_hostname && (valid_hostname_buf = g_hostname_to_ascii(proposed_hostname))) { + /* verify caller has correct permissions via polkit */ + is_authed = polkit_try_auth(bus_name, "org.freedesktop.hostname1.set-hostname", policykit_auth); - check_length = strnlen(proposed_hostname, bad_length); + switch(is_authed) { - if(check_length < bad_length && !sethostname(proposed_hostname, check_length)) - ret = TRUE; + case AUTHORIZED_NATIVELY: + case AUTHORIZED_BY_PROMPT: + try_to_set = TRUE; + break; + + case UNAUTHORIZED_NATIVELY: + case UNAUTHORIZED_FAILED_PROMPT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EACCES", "Insufficient permissions to set hostname."); + break; + + case ERROR_BADBUS: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided bus name is invalid."); + break; + + case ERROR_BADACTION: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided action ID is invalid."); + break; + + case ERROR_GENERIC: + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set hostname for unknown reason."); + break; } - if(ret) - hostname1_complete_set_hostname(hn1_passed_interf, invoc); + /* verify passed hostname's validity */ + if(try_to_set && proposed_hostname && (valid_hostname_buf = g_hostname_to_ascii(proposed_hostname))) { + + check_length = strnlen(valid_hostname_buf, MAXHOSTNAMELEN + 1); + + if(check_length > MAXHOSTNAMELEN) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ENAMETOOLONG", "Hostname string exceeded maximum length."); + g_free(valid_hostname_buf); + + } else if(sethostname(proposed_hostname, check_length)) { - if(proposed_hostname) - g_free(proposed_hostname); - if(valid_hostname_buf) - g_free(valid_hostname_buf); + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set hostname for unknown reason."); + g_free(valid_hostname_buf); + + } else { + + HOSTNAME = valid_hostname_buf; + hostname1_set_hostname(hn1_passed_interf, HOSTNAME); + g_ptr_array_add(hostnamed_freeable, valid_hostname_buf); + ret = TRUE; + hostname1_complete_set_hostname(hn1_passed_interf, invoc); + } + } return ret; } @@ -153,7 +194,76 @@ on_handle_set_static_hostname(Hostname1 *hn1_passed_interf, GDBusMethodInvocation *invoc, const gchar *greet, gpointer data) { - return FALSE; + + GVariant *params; + gchar *proposed_static_hostname, *valid_static_hostname_buf; + const gchar *bus_name; + gboolean policykit_auth, ret, try_to_set; + size_t check_length; + check_auth_result is_authed; + + proposed_static_hostname = NULL; + ret = try_to_set = FALSE; + + params = g_dbus_method_invocation_get_parameters(invoc); + g_variant_get(params, "(sb)", &proposed_static_hostname, &policykit_auth); + bus_name = g_dbus_method_invocation_get_sender(invoc); + + /* verify caller has correct permissions via polkit */ + is_authed = polkit_try_auth(bus_name, "org.freedesktop.hostname1.set-static-hostname", policykit_auth); + + switch(is_authed) { + + case AUTHORIZED_NATIVELY: + case AUTHORIZED_BY_PROMPT: + try_to_set = TRUE; + break; + + case UNAUTHORIZED_NATIVELY: + case UNAUTHORIZED_FAILED_PROMPT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EACCES", "Insufficient permissions to set static hostname."); + break; + + case ERROR_BADBUS: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided bus name is invalid."); + break; + + case ERROR_BADACTION: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided action ID is invalid."); + break; + + case ERROR_GENERIC: + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set static hostname for unknown reason."); + break; + } + + /* verify passed hostname's validity */ + if(try_to_set && proposed_static_hostname && (valid_static_hostname_buf = g_hostname_to_ascii(proposed_static_hostname))) { + + check_length = strnlen(valid_static_hostname_buf, MAXHOSTNAMELEN + 1); + + if(check_length > MAXHOSTNAMELEN) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ENAMETOOLONG", "Static hostname string exceeded maximum length."); + g_free(valid_static_hostname_buf); + + } else if(!(STATIC_HOSTNAME = valid_static_hostname_buf)) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set static hostname for unknown reason."); + g_free(valid_static_hostname_buf); + + } else { + + g_strdelimit(STATIC_HOSTNAME, " ", '-'); + hostname1_set_static_hostname(hn1_passed_interf, STATIC_HOSTNAME); + g_ptr_array_add(hostnamed_freeable, valid_static_hostname_buf); + ret = (!sethostname(valid_static_hostname_buf, MAXHOSTNAMELEN)) ? TRUE : FALSE; /* TODO set /etc/myname, guarantee domain or substitue .home.network" */ + hostname1_complete_set_static_hostname(hn1_passed_interf, invoc); + } + } + + return ret; } static gboolean @@ -161,7 +271,97 @@ on_handle_set_pretty_hostname(Hostname1 *hn1_passed_interf, GDBusMethodInvocation *invoc, const gchar *greet, gpointer data) { - return FALSE; + + GVariant *params; + gchar *proposed_pretty_hostname, *valid_pretty_hostname_buf, *computed_static_hostname; + const gchar *bus_name; + gboolean policykit_auth, ret, try_to_set; + size_t check_length; + check_auth_result is_authed; + GKeyFile *config; + + config = g_key_file_new(); + proposed_pretty_hostname = NULL; + ret = try_to_set = FALSE; + + params = g_dbus_method_invocation_get_parameters(invoc); + g_variant_get(params, "(sb)", &proposed_pretty_hostname, &policykit_auth); + bus_name = g_dbus_method_invocation_get_sender(invoc); + + /* verify caller has correct permissions via polkit */ + is_authed = polkit_try_auth(bus_name, "org.freedesktop.hostname1.set-pretty-hostname", policykit_auth); + + switch(is_authed) { + + case AUTHORIZED_NATIVELY: + case AUTHORIZED_BY_PROMPT: + try_to_set = TRUE; + break; + + case UNAUTHORIZED_NATIVELY: + case UNAUTHORIZED_FAILED_PROMPT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EACCES", "Insufficient permissions to set pretty hostname."); + break; + + case ERROR_BADBUS: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided bus name is invalid."); + break; + + case ERROR_BADACTION: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided action ID is invalid."); + break; + + case ERROR_GENERIC: + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set pretty hostname for unknown reason."); + break; + } + + /* verify passed hostname's validity */ + if(try_to_set && proposed_pretty_hostname && (valid_pretty_hostname_buf = g_locale_to_utf8(proposed_pretty_hostname, -1, 0, 0, NULL))) { + + check_length = strnlen(valid_pretty_hostname_buf, MAXHOSTNAMELEN + 1); + + if(check_length > MAXHOSTNAMELEN) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ENAMETOOLONG", "Static hostname string exceeded maximum length."); + g_free(valid_pretty_hostname_buf); + + } else if(!(PRETTY_HOSTNAME = valid_pretty_hostname_buf)) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set pretty hostname for unknown reason."); + g_free(valid_pretty_hostname_buf); + + } else { + + hostname1_set_pretty_hostname(hn1_passed_interf, PRETTY_HOSTNAME); + g_ptr_array_add(hostnamed_freeable, valid_pretty_hostname_buf); + hostname1_complete_set_pretty_hostname(hn1_passed_interf, invoc); + ret = TRUE; + + if(g_key_file_load_from_file(config, "/etc/machine-info", G_KEY_FILE_NONE, NULL)) { + + g_key_file_set_string(config, "hostnamed", "PRETTY_HOSTNAME", valid_pretty_hostname_buf); + + if((computed_static_hostname = g_hostname_to_ascii(PRETTY_HOSTNAME))) { + + g_strdelimit(computed_static_hostname, " ", '-'); + hostname1_set_static_hostname(hn1_passed_interf, computed_static_hostname); + STATIC_HOSTNAME = computed_static_hostname; + g_ptr_array_add(hostnamed_freeable, computed_static_hostname); + g_key_file_set_string(config, "hostnamed", "StaticHostname", computed_static_hostname); + + } else + g_free(computed_static_hostname); + } + + } + } + + g_key_file_save_to_file(config, "/etc/machine-info", NULL); + g_key_file_unref(config); + + return ret; } static gboolean @@ -169,7 +369,86 @@ on_handle_set_chassis(Hostname1 *hn1_passed_interf, GDBusMethodInvocation *invoc, const gchar *greet, gpointer data) { - return FALSE; + + GVariant *params; + gchar *proposed_chassis_name, *valid_chassis_name_buf; + const gchar *bus_name; + gboolean policykit_auth, ret, try_to_set; + check_auth_result is_authed; + GKeyFile *config; + + config = g_key_file_new(); + proposed_chassis_name = NULL; + ret = try_to_set = FALSE; + valid_chassis_name_buf = (gchar *)g_malloc0(8192); + + params = g_dbus_method_invocation_get_parameters(invoc); + g_variant_get(params, "(sb)", &proposed_chassis_name, &policykit_auth); + bus_name = g_dbus_method_invocation_get_sender(invoc); + + g_strlcpy(valid_chassis_name_buf, proposed_chassis_name, (gsize)64); + + /* verify caller has correct permissions via polkit */ + is_authed = polkit_try_auth(bus_name, "org.freedesktop.hostname1.set-chassis", policykit_auth); + + switch(is_authed) { + + case AUTHORIZED_NATIVELY: + case AUTHORIZED_BY_PROMPT: + try_to_set = TRUE; + break; + + case UNAUTHORIZED_NATIVELY: + case UNAUTHORIZED_FAILED_PROMPT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EACCES", "Insufficient permissions to set chassis type."); + break; + + case ERROR_BADBUS: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided bus name is invalid."); + break; + + case ERROR_BADACTION: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided action ID is invalid."); + break; + + case ERROR_GENERIC: + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set chassis type for unknown reason."); + break; + } + + /* verify passed chassis type's validity */ + if(try_to_set && proposed_chassis_name) { + + if(!is_valid_chassis_type(proposed_chassis_name)) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Chassis type must be 'desktop', 'laptop', 'server', 'tablet', 'handset', 'vm', or 'container'."); + g_free(valid_chassis_name_buf); + + } else if(!(CHASSIS = valid_chassis_name_buf)) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set chassis type for unknown reason."); + g_free(valid_chassis_name_buf); + + } else { + + hostname1_set_chassis(hn1_passed_interf, CHASSIS); + g_ptr_array_add(hostnamed_freeable, valid_chassis_name_buf); + hostname1_complete_set_chassis(hn1_passed_interf, invoc); + + if(g_key_file_load_from_file(config, "/etc/machine-info", G_KEY_FILE_NONE, NULL)) { + + ret = TRUE; + g_key_file_set_string(config, "hostnamed", "ChassisType", valid_chassis_name_buf); + + } + } + } + + g_key_file_save_to_file(config, "/etc/machine-info", NULL); + g_key_file_unref(config); + + return ret; } static gboolean @@ -177,7 +456,80 @@ on_handle_set_icon_name(Hostname1 *hn1_passed_interf, GDBusMethodInvocation *invoc, const gchar *greet, gpointer data) { - return FALSE; + + GVariant *params; + gchar *proposed_icon_name, *valid_icon_name_buf; + const gchar *bus_name; + gboolean policykit_auth, ret, try_to_set; + check_auth_result is_authed; + GKeyFile *config; + + config = g_key_file_new(); + proposed_icon_name = NULL; + ret = try_to_set = FALSE; + + params = g_dbus_method_invocation_get_parameters(invoc); + g_variant_get(params, "(sb)", &proposed_icon_name, &policykit_auth); + bus_name = g_dbus_method_invocation_get_sender(invoc); + + /* verify caller has correct permissions via polkit */ + is_authed = polkit_try_auth(bus_name, "org.freedesktop.hostname1.set-icon-name", policykit_auth); + + switch(is_authed) { + + case AUTHORIZED_NATIVELY: + case AUTHORIZED_BY_PROMPT: + try_to_set = TRUE; + break; + + case UNAUTHORIZED_NATIVELY: + case UNAUTHORIZED_FAILED_PROMPT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EACCES", "Insufficient permissions to set icon name."); + break; + + case ERROR_BADBUS: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided bus name is invalid."); + break; + + case ERROR_BADACTION: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.EFAULT", "Provided action ID is invalid."); + break; + + case ERROR_GENERIC: + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set icon name for unknown reason."); + break; + } + + /* verify passed chassis type's validity */ + if(try_to_set && proposed_icon_name) { + + g_strlcpy(valid_icon_name_buf, proposed_icon_name, (gsize)64); + + if(!(ICON = valid_icon_name_buf)) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.hostname1.Error.ECANCELED", "Failed to set icon name for unknown reason."); + g_free(valid_icon_name_buf); + + } else { + + hostname1_set_icon_name(hn1_passed_interf, ICON); + g_ptr_array_add(hostnamed_freeable, valid_icon_name_buf); + hostname1_complete_set_icon_name(hn1_passed_interf, invoc); + + if(g_key_file_load_from_file(config, "/etc/machine-info", G_KEY_FILE_NONE, NULL)) { + + ret = TRUE; + g_key_file_set_string(config, "hostnamed", "IconName", valid_icon_name_buf); + + } + } + } + + g_key_file_save_to_file(config, "/etc/machine-info", NULL); + g_key_file_unref(config); + + return ret; } /* note: all hostnamed/hostname1's properties are read-only, @@ -189,21 +541,34 @@ on_handle_set_icon_name(Hostname1 *hn1_passed_interf, const gchar * our_get_hostname() { - if(HOSTNAME) + gchar *hostname_buf; + hostname_buf = (gchar *)g_malloc0(MAXHOSTNAMELEN); + + if(gethostname(hostname_buf, MAXHOSTNAMELEN)) + return "localhost.home.network"; /* TODO bomb out here probably */ + + else if(!g_strcmp0(HOSTNAME, hostname_buf)) { + + g_free(hostname_buf); return HOSTNAME; + } - return "localhost"; + g_ptr_array_add(hostnamed_freeable, hostname_buf); + HOSTNAME = hostname_buf; + hostname1_set_hostname(hostnamed_interf, HOSTNAME); + + return HOSTNAME; } const gchar * our_get_static_hostname() { - if(STATIC_HOSTNAME) + if(STATIC_HOSTNAME && g_strcmp0(STATIC_HOSTNAME, "")) return STATIC_HOSTNAME; else if(HOSTNAME) return HOSTNAME; - return "localhost"; + return "localhost.home.network"; } const gchar * @@ -263,7 +628,8 @@ our_get_kernel_release() { const gchar * our_get_os_cpename() { - return "ONEDAY"; + /* XXX needs to parse /etc/os-release (fallback to /usr/local/lib/os-release) */ + return ""; } const gchar * @@ -275,8 +641,8 @@ our_get_os_pretty_name() { /* --- end method/property/dbus signal code, begin bus/name handlers --- */ static void hostnamed_on_bus_acquired(GDBusConnection *conn, - const gchar *name, - gpointer user_data) { + const gchar *name, + gpointer user_data) { g_printf("got bus/name, exporting %s's interface...\n", name); @@ -384,7 +750,7 @@ int main() { CHASSIS = ICON = OS_CPENAME = 0; KERN_NAME = KERN_RELEASE = KERN_VERS = 0; HOSTNAME = STATIC_HOSTNAME = PRETTY_HOSTNAME = NULL; - + set_signal_handlers(); if(!determine_chassis_and_icon() || !set_uname_properties() || !set_names()) @@ -442,8 +808,8 @@ gboolean set_names() { strncpy(ret, hostname_buf, hostname_divider); */ /* (3) set PRETTY_HOSTNAME */ - if(g_key_file_load_from_file(config, "/etc/systemd_compat.conf", G_KEY_FILE_NONE, NULL) - && (pretty_hostname_buf = g_key_file_get_value(config, "hostnamed", "PrettyHostname", NULL))) + if(g_key_file_load_from_file(config, "/etc/machine-info", G_KEY_FILE_NONE, NULL) + && (pretty_hostname_buf = g_key_file_get_value(config, "hostnamed", "PRETTY_HOSTNAME", NULL))) PRETTY_HOSTNAME = pretty_hostname_buf; else PRETTY_HOSTNAME = ""; @@ -644,3 +1010,18 @@ gboolean up_native_get_sensordev(const char * id, struct sensordev * snsrdev) { return FALSE; } + +static gboolean is_valid_chassis_type(gchar *test) { + + if(!g_strcmp0(test, "desktop") || + !g_strcmp0(test, "laptop") || + !g_strcmp0(test, "server") || + !g_strcmp0(test, "tablet") || + !g_strcmp0(test, "handset") || + !g_strcmp0(test, "vm") || + !g_strcmp0(test, "container") || + !g_strcmp0(test, "")) + return TRUE; + + return FALSE; +}