X-Git-Url: https://uglyman.kremlin.cc/gitweb/gitweb.cgi?p=systembsd.git;a=blobdiff_plain;f=src%2Finterfaces%2Ftimedated%2Ftimedated.c;h=cba6138bada05a77383bbb42ec5d34f626091e2b;hp=0aee4dc430764a6ff1ebb5c22d2264370a509d22;hb=06407d3ed6ecd095261823d3c488d1947c9a19c3;hpb=a8f7171993dc1467e353bbd1f7c712c31f2b846b diff --git a/src/interfaces/timedated/timedated.c b/src/interfaces/timedated/timedated.c index 0aee4dc..cba6138 100644 --- a/src/interfaces/timedated/timedated.c +++ b/src/interfaces/timedated/timedated.c @@ -20,8 +20,11 @@ #include #include +#include +#include #include #include +#include #include #include @@ -33,6 +36,8 @@ #include "../../util.h" +#define TZNAME_MAX PATH_MAX + GPtrArray *timedated_freeable; Timedate1 *timedated_interf; @@ -101,18 +106,43 @@ on_handle_set_time(Timedate1 *td1_passed_interf, return FALSE; } - if(relative) { + if(!proposed_time) { + + timedate1_complete_set_time(td1_passed_interf, invoc); + return TRUE; - new_time = (struct timespec *) g_malloc0(sizeof(struct timespec)); + } else if(relative) { cur_time = g_get_real_time(); - /* LEFT OFF HERE 9/13 */ return FALSE; - } else if(proposed_time >= 0) { - new_time = (struct timespec *) g_malloc0(sizeof(struct timespec)); - new_time->tv_sec = proposed_time; - new_time->tv_nsec = 0; - g_ptr_array_add(timedated_freeable, new_time); + if(proposed_time < 0 && cur_time + proposed_time > cur_time) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EINVAL", "Resultant time out of bounds."); + return FALSE; + + } else if(proposed_time > 0 && cur_time + proposed_time < cur_time) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EINVAL", "Resultant time out of bounds."); + return FALSE; + } + + new_time = mktimespec(proposed_time); + + if(!clock_settime(CLOCK_REALTIME, new_time)) { + + timedate1_complete_set_time(td1_passed_interf, invoc); + return TRUE; + + } else { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.ECANCELED", "Failed to set system time for unknown reasons."); + return FALSE; + } + + } else if(proposed_time > 0) { + + + new_time = mktimespec(proposed_time); if(!clock_settime(CLOCK_REALTIME, new_time)) { @@ -124,9 +154,10 @@ on_handle_set_time(Timedate1 *td1_passed_interf, g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.ECANCELED", "Failed to set system time for unknown reasons."); return FALSE; } + } else { - g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.EDOM", "Provided time results in a negative clock value."); + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EINVAL", "Resultant time out of bounds."); return FALSE; } } @@ -136,7 +167,102 @@ on_handle_set_timezone(Timedate1 *td1_passed_interf, GDBusMethodInvocation *invoc, const gchar *greet, gpointer data) { - return FALSE; + + GVariant *params; + gchar *proposed_tz; + const gchar *bus_name; + gboolean policykit_auth; + check_auth_result is_authed; + + gchar *tz_target_path; + struct stat *statbuf; + extern int errno; + + params = g_dbus_method_invocation_get_parameters(invoc); + g_variant_get(params, "(sb)", &proposed_tz, &policykit_auth); + bus_name = g_dbus_method_invocation_get_sender(invoc); + + is_authed = polkit_try_auth(bus_name, "org.freedesktop.timedate1.set-timezone", policykit_auth); + + switch(is_authed) { + + case AUTHORIZED_NATIVELY: + case AUTHORIZED_BY_PROMPT: + break; + + case UNAUTHORIZED_NATIVELY: + case UNAUTHORIZED_FAILED_PROMPT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EACCES", "Insufficient permissions to set timezone."); + return FALSE; + + case ERROR_BADBUS: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EFAULT", "Provided bus name is invalid."); + return FALSE; + + case ERROR_BADACTION: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EFAULT", "Provided action ID is invalid."); + return FALSE; + + case ERROR_GENERIC: + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.ECANCELED", "Failed to set timezone for unknown reasons."); + return FALSE; + } + + statbuf = (struct stat*) calloc(1, sizeof(struct stat)); + tz_target_path = (gchar *) calloc(1, TZNAME_MAX); + + g_ptr_array_add(timedated_freeable, statbuf); + g_ptr_array_add(timedated_freeable, tz_target_path); + + strlcat(tz_target_path, TZDIR, TZNAME_MAX); + strlcat(tz_target_path, "/", TZNAME_MAX); + strlcat(tz_target_path, proposed_tz, TZNAME_MAX); + + if(strstr(tz_target_path, "../")) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EBADF", "Provided timezone is invalid."); + return FALSE; + } + + if(!statbuf) + return FALSE; + + if(lstat(tz_target_path, statbuf)) { + + switch(errno) { + + case ENOENT: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.ENOENT", "Specified timezone does not exist."); + break; + + default: + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EBADF", "Specified timezone is invalid."); + break; + } + + return FALSE; + } + + if(!S_ISREG(statbuf->st_mode)) { + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.EBADF", "Specified path is of an inappropriate type."); + return FALSE; + } + + memset(statbuf, 0, sizeof statbuf); + + if(!lstat(TZDEFAULT, statbuf)) + if(remove(TZDEFAULT)) + return FALSE; + + if(symlink(tz_target_path, TZDEFAULT)) + return FALSE; + + + timedate1_complete_set_timezone(td1_passed_interf, invoc); + + return TRUE; } static gboolean @@ -144,7 +270,9 @@ on_handle_set_local_rtc(Timedate1 *td1_passed_interf, GDBusMethodInvocation *invoc, const gchar *greet, gpointer data) { - return FALSE; + + g_dbus_method_invocation_return_dbus_error(invoc, "org.freedesktop.timedate1.Error.ENODEV", "Unix RTC must be in UTC."); + return TRUE; } static gboolean @@ -190,15 +318,19 @@ our_get_timezone() { g_printf("%s is not a symlink! attempting to match checksums in %s...\n", OS_LOCALTIME, OS_TIMEZONE_PATH); hash_to_match = get_file_sha256(OS_LOCALTIME); - ret = lookup_hash(hash_to_match); + /* ret = lookup_hash(hash_to_match); */ + return FALSE; /* TODO fix me for real */ if(hash_to_match) g_free(hash_to_match); } + + return ret; } +/* Unix time must be in UTC. */ gboolean our_get_local_rtc() { @@ -346,8 +478,8 @@ int main() { set_signal_handlers(); - if(!build_lookup_table()) - return 1; + /*if(!build_lookup_table()) + return 1; */ timedated_loop = g_main_loop_new(NULL, TRUE); timedated_freeable = g_ptr_array_new(); @@ -421,7 +553,7 @@ static struct timezone_checksum_pair parse_timezone_path(gchar **pair) { return ret; } -/* TODO need to deconstruct tz_table on exit */ +/* TODO need to deconstruct tz_table on exit static gboolean build_lookup_table() { gchar *find_cmd, **map_pairs, *find_output, *path_buf, *sum_buf, **entry_buf; @@ -472,4 +604,32 @@ static gchar *lookup_hash(gchar *hash) { i++; return NULL; +}*/ + +/* takes number of microseconds since epoch and returns a + * ptr to a timespec suitable to be passed to clock_settime(3) + */ +static struct timespec* mktimespec(gint64 us) { + + long nanoseconds; + time_t seconds; + + gint64 div_buf_remainder, div_buf_s, div_buf_ns; + struct timespec *ret; + + div_buf_s = (us / 1000000); /* us / 10^6 = s */ + div_buf_remainder = (us % 1000000); /* fraction of second lost from prev. line */ + div_buf_ns = div_buf_remainder * 1000; /* us * 10^3 = ns */ + + seconds = (time_t) div_buf_s; /* porting note: most systems use 32 bit time, adjust accordingly */ + nanoseconds = (long) div_buf_ns; + + ret = (struct timespec *) calloc(1, sizeof(struct timespec)); + + ret->tv_sec = seconds; + ret->tv_nsec = nanoseconds; + + g_ptr_array_add(timedated_freeable, ret); + + return ret; }