X-Git-Url: https://uglyman.kremlin.cc/gitweb/gitweb.cgi?p=systembsd.git;a=blobdiff_plain;f=src%2Finterfaces%2Ftimedated%2Ftimedated.c;h=f76850c4f6fadd270307b4c0c15ffb96c0e5e4fe;hp=265a33f020c041c595186496474fb350f7dd9680;hb=483e90b704090617eba8bf030d23eca616063b21;hpb=712eb32987872a6515e956246c0695fda032eb98

diff --git a/src/interfaces/timedated/timedated.c b/src/interfaces/timedated/timedated.c
index 265a33f..f76850c 100644
--- a/src/interfaces/timedated/timedated.c
+++ b/src/interfaces/timedated/timedated.c
@@ -23,10 +23,13 @@
 
 #include <glib/gprintf.h>
 #include <glib-unix.h>
+#include <polkit/polkit.h>
 
 #include "timedated-gen.h"
 #include "timedated.h"
 
+#include "../../polkit-auth.h"
+
 GPtrArray *timedated_freeable;
 Timedate1 *timedated_interf;
 
@@ -48,20 +51,20 @@ on_handle_set_hostname(Timedate1 *hn1_passed_interf,
 /*const gchar *
 our_get_hostname() {
 
-	gchar *hostname_buf, *ret;
-	size_t hostname_divider;
+    gchar *hostname_buf, *ret;
+    size_t hostname_divider;
 
-	hostname_buf = (gchar*) g_malloc0(MAXHOSTNAMELEN);
-	ret          = (gchar*) g_malloc0(MAXHOSTNAMELEN);
-	g_ptr_array_add(timedated_freeable, hostname_buf);
-	g_ptr_array_add(timedated_freeable, ret);
+    hostname_buf = (gchar*) g_malloc0(MAXHOSTNAMELEN);
+    ret          = (gchar*) g_malloc0(MAXHOSTNAMELEN);
+    g_ptr_array_add(timedated_freeable, hostname_buf);
+    g_ptr_array_add(timedated_freeable, ret);
 
-	if(gethostname(hostname_buf, MAXHOSTNAMELEN))
-		return "";
+    if(gethostname(hostname_buf, MAXHOSTNAMELEN))
+        return "";
 
-	hostname_divider = strcspn(hostname_buf, ".");
+    hostname_divider = strcspn(hostname_buf, ".");
 
-	return strncpy(ret, hostname_buf, hostname_divider);
+    return strncpy(ret, hostname_buf, hostname_divider);
 }*/
 
 /* --- end method/property/dbus signal code, begin bus/name handlers --- */
@@ -70,7 +73,7 @@ static void timedated_on_bus_acquired(GDBusConnection *conn,
                                       const gchar *name,
                                       gpointer user_data) {
 
-    g_print("got bus/name, exporting %s's interface...\n", name);
+    g_printf("got bus/name, exporting %s's interface...\n", name);
 
     timedated_interf = timedate1_skeleton_new();
 
@@ -96,7 +99,7 @@ static void timedated_on_bus_acquired(GDBusConnection *conn,
 }
 
 static void timedated_on_name_acquired(GDBusConnection *conn,
-    		                           const gchar *name,
+                                       const gchar *name,
                                        gpointer user_data) {
 
    g_printf("success!\n"); 
@@ -142,12 +145,22 @@ gboolean unix_sig_terminate_handler(gpointer data) {
     return G_SOURCE_REMOVE;
 }
 
+void set_signal_handlers() {
+
+    /* we don't care about its descriptor, we never need to unregister these */
+    g_unix_signal_add(SIGINT,  unix_sig_terminate_handler, NULL);
+    g_unix_signal_add(SIGHUP,  unix_sig_terminate_handler, NULL);
+    g_unix_signal_add(SIGTERM, unix_sig_terminate_handler, NULL);
+}
+
 int main() {
 
-	timedated_loop = g_main_loop_new(NULL, TRUE);
-	timedated_freeable = g_ptr_array_new();
+    set_signal_handlers();
+
+    timedated_loop = g_main_loop_new(NULL, TRUE);
+    timedated_freeable = g_ptr_array_new();
 
-	 bus_descriptor = g_bus_own_name(G_BUS_TYPE_SYSTEM,
+     bus_descriptor = g_bus_own_name(G_BUS_TYPE_SYSTEM,
                                     "org.freedesktop.timedate1",
                                     G_BUS_NAME_OWNER_FLAGS_NONE,
                                     timedated_on_bus_acquired,
@@ -156,12 +169,15 @@ int main() {
                                     NULL,
                                     NULL);
 
-	g_main_loop_run(timedated_loop);
-	g_main_loop_unref(timedated_loop);
+    g_main_loop_run(timedated_loop);
+    /* runs until single g_main_loop_quit() call is raised inside <interface>_mem_clean() */
+    g_main_loop_unref(timedated_loop);
 
-	g_bus_unown_name(bus_descriptor);
+    /* guaranteed unownable */
+    g_bus_unown_name(bus_descriptor);
 
-	timedated_mem_clean();
+    /* at this point no operations can occur with our data, it is safe to free it + its container */
+    g_ptr_array_free(timedated_freeable, TRUE);
 
-	return 0;
+    return 0;
 }